Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prevent users from editing locked plan #228

Merged
merged 3 commits into from
Nov 10, 2022
Merged

feat: prevent users from editing locked plan #228

merged 3 commits into from
Nov 10, 2022

Conversation

AaronPlave
Copy link
Contributor

@AaronPlave AaronPlave commented Nov 10, 2022 •
edited
Loading

Closes #230

  • Subscribe to plan locked status
  • Implement PlanLockedModal which appears when plan is locked and gives the user the option to go to the review or go back to all plans. This modal is not dismissible.

@AaronPlave AaronPlave temporarily deployed to test-workflow November 10, 2022 18:51 Inactive
@AaronPlave AaronPlave added the feature New feature or request label Nov 10, 2022
@AaronPlave AaronPlave added this to the 1.0.0 milestone Nov 10, 2022
@AaronPlave AaronPlave self-assigned this Nov 10, 2022
@AaronPlave AaronPlave marked this pull request as ready for review November 10, 2022 18:56
@AaronPlave AaronPlave requested a review from a team as a code owner November 10, 2022 18:56
@AaronPlave AaronPlave requested review from camargo, jeffpamer and duranb and removed request for jeffpamer and duranb November 10, 2022 18:56
@camargo camargo removed this from the 1.0.0 milestone Nov 10, 2022
@AaronPlave AaronPlave temporarily deployed to test-workflow November 10, 2022 19:10 Inactive
@AaronPlave AaronPlave mentioned this pull request Nov 10, 2022
Closed
@camargo camargo changed the title Prevent users from editing locked plan feat: prevent users from editing locked plan Nov 10, 2022
camargo
camargo reviewed Nov 10, 2022
View reviewed changes
src/utilities/modal.ts Outdated Show resolved Hide resolved
@AaronPlave AaronPlave temporarily deployed to test-workflow November 10, 2022 23:16 Inactive
@camargo camargo temporarily deployed to test-workflow November 10, 2022 23:20 Inactive
@camargo camargo merged commit 7e9e459 into develop Nov 10, 2022
@camargo camargo deleted the feat/sub-plan-locked branch November 10, 2022 23:30
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@AaronPlave
feat: prevent users from editing locked plan (#228)
eef885b 
* Subscribe to plan lock status and prevent user from editing plan if locked
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@AaronPlave
feat: prevent users from editing locked plan (#228)
3e89bbe 
* Subscribe to plan lock status and prevent user from editing plan if locked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camargo camargo camargo approved these changes

Assignees

@AaronPlave AaronPlave

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent users from editing locked plans
2 participants
@AaronPlave @camargo